Use major version ref of action in workflow #168
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
At the time the workflow was written the authors of the rtCamp/action-slack-notify GitHub Action did not provide a major version ref. This meant that it was necessary to pin the action to a specific version. Since then, a few new patch releases have been made, meaning an outdated version of the action was in use as a consequence of the pinning. The action now offers a `v2` major ref. Use of this ref will cause the workflow to benefit from ongoing development to the action up until such time as a new major release is made, at which time we would need to evaluate whether any changes to the workflow are required by the breaking change that triggered the major release before updating the major ref (e.g., `v3`).
per1234
added
type: enhancement
silvanocerza
approved these changes
Apr 6, 2021
rsora
added
criticality: low
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At the time the workflow was written the authors of the
rtCamp/action-slack-notifyGitHub Action did not provide a major version ref. This meant that it was necessary to pin the action to a specific version.Since then, a few new patch releases have been made, meaning an outdated version of the action was in use as a consequence of the pinning.
The action now offers a
v2major ref. Use of this ref will cause the workflow to benefit from ongoing development to the action up until such time as a new major release is made, at which time we would need to evaluate whether any changes to the workflow are required by the breaking change that triggered the major release before updating the major ref (e.g.,v3).One of the changes made since the v2.1.0 release that was pinned is the switch from docker.io to ghcr.io as the action's Docker container registry in response to rtCamp/action-slack-notify#52
It's possible this change will help to avoid future spurious workflow failures such as the one experienced in https://github.com/arduino/arduino-lint/actions/runs/714065327